search

jasonmccreary / laravel-test-assertions

A set of helpful assertions when testing Laravel applications.
321 stars 34 forks source link

assertActionUsesMiddleware and assertRouteUsesMiddleware doesn't respect excludedMiddleware #37

Closed chrillep closed 2 years ago

chrillep commented 2 years ago

if using withoutMiddleware https://laravel.com/docs/9.x/middleware#excluding-middleware

the middleware will still show up as being used on assertActionUsesMiddleware and assertRouteUsesMiddleware

chrillep commented 2 years ago

I'll give an example if needed. just wanted to get my finding out of the way, before I forgot 😊

jasonmccreary commented 2 years ago

@chrillep, no, the issue is pretty straightforward. Probably won't get to the fix for a while though. Feel free to try a PR.

chrillep commented 2 years ago

@chrillep, no, the issue is pretty straightforward. Probably won't get to the fix for a while though. Feel free to try a PR.

happily someone else fixed this 🚀

however the Fix isn't releases yet. so until then using dev-master 😊

https://packagist.org/packages/jasonmccreary/laravel-test-assertions#dev-master

thanks fo making my testlife easier 🎉

jasonmccreary commented 2 years ago

@chrillep, is it working for you as expected on dev-master? If so, I'll close this and tag a release.

chrillep commented 2 years ago

@chrillep, is it working for you as expected on dev-master? If so, I'll close this and tag a release.

yes it works. ty :) 👍🏼