search

jasonmimick / atlas-osb

DEPRECATED: See https://github.com/mongodb/atlas-osb
https://github.com/mongodb/atlas-osb
Apache License 2.0
0 stars 2 forks source link

Add Plan Instance Termination Protection #35

Closed jasonmimick closed 4 years ago

jasonmimick commented 4 years ago

We should add a bool for EnablePlanTerminationProtection and add this as a field to Plan (or similar) The field in Plan should support a default value, which can some from an env variable ATLAS_BROKER_ENABLE_PLAN_TERMINATION_PROTECTION default is false.

Then if the termination protection is enabled, then when deleting a plan we should:

then log all this, but really delete the service instance and don't fail the /deprovision broker call

@vasilevp - please review this and provide any feedback.

Originally posted by @jasonmimick in https://github.com/jasonmimick/atlas-osb/issues/17#issuecomment-656713992

jasonmimick commented 4 years ago

This is out of scope for current beta. Closing issue.