Adds moment-range support

jasonmit / ember-cli-moment-shim

ember-cli shim for momentjs

MIT License

33 stars 59 forks source link

Adds moment-range support #163

Closed willviles closed 6 years ago

willviles commented 6 years ago

This PR adds moment-range support for both browser and Fastboot builds.

Please let me know if you're willing to merge this PR and I'd be happy to write some tests and update the README before merging into master.

[x] Implementation
[ ] Unit Tests
[ ] Document in README

jasonmit commented 6 years ago

I'd rather not add anymore features to this addon as the future plan makes it no longer necessary.

https://github.com/jasonmit/ember-cli-moment-shim/issues/164

rtablada commented 6 years ago

@willviles the happy path is to use ember-auto-import and npm install moment-range.

This has the added benefit of allowing host applications to require their own version of moment-range and it will make autocomplete for editors work better than it would if moment-range is buried as a child dependency.