jasonmit / ember-i18n-cp-validations

ember-i18n support for ember-cp-validations
MIT License
21 stars 16 forks source link

Read i18nDescriptionKey from Validator options. #11

Closed caalle closed 8 years ago

caalle commented 8 years ago

Fixes #10

Allow translation of Validator descriptions by setting i18nDescriptionKey. Not entirely sure about the key name.

Let me know what you think.

jasonmit commented 8 years ago

Ignore houndci, I'll fix that soon. Maybe lets change i18nDescriptionKey to just descriptionKey, thoughts?

Looks good and thanks for doing this :+1:

caalle commented 8 years ago

Sounds good, that will make it easier to type as well. Updated the pull request.

jasonmit commented 8 years ago

Published under 2.3.0. Thanks again @caalle :+1:

caalle commented 8 years ago

Nice! Thank you for the quick action.