Closed blimmer closed 8 years ago
Should we release this as 1.0? Technically we can release as 0.4.0 and still be safe to make breaking API changes within semver but, if we're happy with this API, I could also see releasing 1.0.0.
cc @jasonmit please have a look.
Looks awesome and thanks for doing this, feel free to merge :+1:
Should we release this as 1.0? Technically we can release as 0.4.0 and still be safe to make breaking API changes within semver but, if we're happy with this API, I could also see releasing 1.0.0.
Sounds good to me, the only thing is I still find allowDirtyTransition
to be a somewhat confusing name. But if we come up with something better we could deprecate and make sure it's backwards compat.
Yeah I don't like allowDirtyTransition
either but I'm really struggling to come up with something better. Do you have any thoughts?
How about shouldCheckIsPageDirty
?
I think that's getting closer, but validate
seems weird.
I think that's getting closer, but validate seems weird.
I edited it to shouldCheckIsPageDirty
because after typing it I felt the same..
Works for me. I'll make those updates. Think we're good to go 1.0 too?
Works for me. I'll make those updates. Think we're good to go 1.0 too?
:+1:
Rebased - will bump package.json and release 1.0 after tests / merge.
Published!
This PR covers everything discussed in https://github.com/jasonmit/ember-onbeforeunload/milestones/0.4.0 .
Ember.Controller