search

jasonmitchell / hallo

MIT License
16 stars 4 forks source link

Split the packages into 3 #53

Closed jchannon closed 3 years ago

jchannon commented 3 years ago

This PR splits the packages into 3, Hallo, Hallo.AspNetCore & Hall.AspNetCore.Mvc.

I also added a raw AspNetCore sample and renamed the existing sample.

Happy to add a Carter and fsharp Giraffe example too

Fixes #51

jasonmitchell commented 3 years ago

This looks great, thanks for this. I'm going to merge it in and then work on #53 to get the build and readme updated for this.

jchannon commented 3 years ago

That’d be cool but I think we’d have to be careful to not conflict with serialiser settings they might already register. What you could do is register a factory though just for use by this lib.

On Sun, 28 Feb 2021 at 18:26, Jason Mitchell notifications@github.com wrote:

Merged #53 https://github.com/jasonmitchell/hallo/pull/53 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jasonmitchell/hallo/pull/53#event-4386373797, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZVJQJSJMN2VHJFWW3IDTTBKDG7ANCNFSM4YIU4QTA .