search

jasonmossing15 / Pong

ECE 383 Lab 2. Create Pong with AF background using FPGA
0 stars 0 forks source link

Grades #1

Open jasonmossing15 opened 10 years ago

jasonmossing15 commented 10 years ago

Prelab: check plus: 10 Required: 40 B: 10 A: 10

toddbranch commented 10 years ago

Prelab - 10

Required - 40 B - 10 A - 10

Use of Git - Check - 4 - Your commit messages are excellent, but you're grouping many different code changes into single commits. I'd encourage you to group commits for like functionality together. For instance, don't mix adding generics, editing headers, and creating the README in a single commit. Code Style - Check Plus - 5 - Some indentation issues - be consistent! But awesome job using generics and a constants package. It looks like you didn't add your constants package to source control - add it next time! There are still a lot of magic numbers in pong_control and pixel_gen - get rid of those. Give me a description in the headers - not much there at this point. README - Check - 17 - Introduce the specifics of the problem before you immediately jump into your state machine solution. But I really like that you split the problem into two complementary state machines. Next time, show me a top-level view of how everything fit together. Show me the key code constructs of how you realized functionality - you're getting there in the code you showed for B Functionality. But be more clear about what speed dictates and the code constructs for other levels of functionality. I like the detail in the Test/Debug section - but show me concrete code errors and code solutions.

Agreed on your Lessons Learned - starting early and working methodically makes you work more efficiently. For thought-intensive exercises like this, all-nighters aren't effective.

Total - 96