search

jasonnutter / vscode-github-pr

VS Code plugin for working with Github PRs.
https://marketplace.visualstudio.com/items?itemName=jasonnutter.github-pr
MIT License
5 stars 3 forks source link

Feature Request: Add an "Edit on Github" function #2

Open drew-wallace opened 7 years ago

drew-wallace commented 7 years ago

My workflow requires me to add @some_other_engineer to the PR in order for them to approve it. I need to put their @ mention in the description for this process to work. Is there anyway you could take advantage of this by using this URL structure:

[https://github.com/github-username/github-repo-name/compare/base-branch...github-username:branch-to-merge-into-base?expand=1&title=Some%20PR%20title%20here&body=Some%20PR%20description%20here]()

Example: https://github.com/jasonnutter/vscode-github-pr/compare/master...jasonnutter:some-other-branch?expand=1&title=Some%20PR%20title%20here&body=Some%20PR%20description%20here

This will take your title and description and inject the text in the PR fields without submitting. This would allow me to edit the PR to add the appropriate @ mentions for my workflow.

jasonnutter commented 7 years ago

@drew-wallace It sounds like you would like to see a prompt added to provide the PR body (in addition to the PR branch and title)? That can definitely be added.

Note, prompting the user to create the PR via github.com is only shown to the user if programmatically creating the PR fails (e.g. the access token doesn't have the correct scope).

drew-wallace commented 7 years ago

I would always want to finish creating the PR on github so that I have access to the @ mention autocomplete features within the comments. Maybe after prompting for the title and description of the PR, the final prompt would be [Create][Edit on GitHub][Cancel]. Clicking edit on github would take me to the PR page with the title and description filled in already (using that link above).