search

jasonnutter / vscode-github-pr

VS Code plugin for working with Github PRs.
https://marketplace.visualstudio.com/items?itemName=jasonnutter.github-pr
MIT License
5 stars 3 forks source link

What personal access token scopes are needed for proper operation? #5

Closed dpmott closed 6 years ago

dpmott commented 6 years ago

What personal access token scopes are needed for proper operation?

I tried using a token with no scopes, and that didn't work. I created a token with 'gist' and 'repo' scopes, and that worked for retrieving a list of PRs and allowing me to view a PR.

However, I'm getting an error in creating a PR: "Github PR: Unable to create PR." with the options to "Create on Github" or "Close".

The docs don't mention which token scopes are needed.

Thanks!

jasonnutter commented 6 years ago

The repo scope should be enough (i.e. for private repos). Have you double checked your other settings are correct, and that the token works if used for something else?

dpmott commented 6 years ago

Thanks for your quick response!

It turns out that this is the error issued when the PR already exists. If a PR for that branch doesn't already exist, it works fine.

Still might be worthwhile to update the docs with a note about the required scope, if you happen to have it opened up for edit at some point.

jasonnutter commented 6 years ago

Ah, makes sense. Can probably have the plugin handle that situation better.

Thanks for the feedback, planning to make a set of updates soon and will include that!