jasonnutter / vscode-github-pr

VS Code plugin for working with Github PRs.
https://marketplace.visualstudio.com/items?itemName=jasonnutter.github-pr
MIT License
5 stars 3 forks source link

Change the default shortcut chord (ctrl+g ctrl+?) #9

Open e7d opened 6 years ago

e7d commented 6 years ago

Hello, The current shortcuts provided bu your extensions works using chorded shortcuts, the first chord being ctrl+g. This would be an issue with Visual Studio Code, as ctrl+g is the standard shortcut for the command Go to Line...: image There also is no option to modify/disable this shortcuts from user settings. I guess that would be the better option. Currently, getting back the default ctrl+g behavior implies to force unset in the keybindings.json all the four chords brought by your extension.

jasonnutter commented 6 years ago

Good feedback, was probably a bad choice for shortcut chord. Will consider changing it.