search

jasonnutter / vscode-search-node-modules

Simple plugin for VS Code that allows you to quickly navigate the file inside your project's node_modules directory.
https://marketplace.visualstudio.com/items?itemName=jasonnutter.search-node-modules
MIT License
60 stars 17 forks source link

Release a new version including support for workspaces #26

Open OriMarron opened 4 years ago

OriMarron commented 4 years ago

(regarding https://github.com/jasonnutter/vscode-search-node-modules/issues/10, https://github.com/jasonnutter/vscode-search-node-modules/pull/11, #13)

Hi, you've merged my PRs for supporting monorepos (which is awesome), but a new version of the extension was not published yet. Could you publish a new version including the changes so people can start using these features?

Thanks

devuxer commented 4 years ago

Do your fixes work for any type of monorepo or just Lerna? I have a very simple setup that's just a parent project with a handful of child projects. No yarn or lerna (just NPM). In any case, thanks for your contributions!

OriMarron commented 4 years ago

To support any repo without any package, all you would need is to add a workspaces field to your package.json file, similiar to how a yarn workspace is configured. Anyway, @jasonnutter has not yet released a new version that includes my PRs, so it's not really relevant

devuxer commented 4 years ago

Cool thx, and hopefully he'll release it soon. The extension is pretty limited if all it can do is search top-level node_modules.

EDIT: wow just noticed he merged your request about a year ago. At one point does the open source community typically consider an open source project abandoned and fork it?

dantman commented 4 years ago

I too would appreciate a release or a fork.

huaize2020 commented 3 years ago

I too would appreciate a release or a fork. Could you publish a new version?