jasononeil / haxelib

Provisional project for the Haxe 3 related haxelib changes.
0 stars 0 forks source link

Stats arent up to date? #29

Closed markknol closed 7 years ago

markknol commented 9 years ago

http://lib.haxe.org/p/tink_xml/ How much time does it take before the stats are updated?

ncannasse commented 9 years ago

It seems that download stats are not saved, but this might be because of @back2dos since this is done as part of haxelib API

back2dos commented 9 years ago

I'm not really sure where this comes from. The call is made in the client:

https://github.com/HaxeFoundation/haxelib/blob/master/src/tools/haxelib/Main.hx#L824

And processed by the server:

https://github.com/HaxeFoundation/haxelib/blob/master/src/tools/haxelib/Repo.hx#L306

I'll look into this next week.

back2dos commented 9 years ago

My guess is maybe the reimplementation of SemVer as an abstract over String caused small changes which make this query fail: https://github.com/HaxeFoundation/haxelib/blob/master/src/tools/haxelib/Repo.hx#L296

And then postInstall is abruptly cancelled by this: https://github.com/HaxeFoundation/haxelib/blob/master/src/tools/haxelib/Repo.hx#L304

And the error is silenced by this pokemon clause: https://github.com/HaxeFoundation/haxelib/blob/master/src/tools/haxelib/Main.hx#L825

ncannasse commented 9 years ago

Let's blame them all !

back2dos commented 9 years ago

I'm not blaming, only thinking out loud ;)

markknol commented 9 years ago

Lol Gotta catch em all!

Simn commented 9 years ago

Haha, "pokemon clause" is brilliant.