Webpack 5 requires dependencies to be absolute path

jasononeil / webpack-haxe-loader

Webpack loader for the Haxe programming language.

MIT License

38 stars 11 forks source link

Webpack 5 requires dependencies to be absolute path #80

Closed elsassph closed 2 years ago

elsassph commented 2 years ago

ensure classpath and watch paths are absolute
fix regression in hxml parsing (with test)

clarkjones commented 2 years ago

Getting a build error:

Module build failed (from ./node_modules/haxe-loader/index.js):
Haxe Loader: Compilation failed

This appears to be a problem introduced in an earlier update though. I went ahead made the same changes in my local 0.10.0 release and it built fine.

yargs-parser seems to be the only version bump with a new major version so maybe that?

clarkjones commented 2 years ago

ok here's a follow up. Reverting yargs-parser did work for me. After a little research I found there is an issue with parsing quotes in updated versions. My web pack build uses --macro "include('...')" in theextra` option shell-parser seems to be a working alternative.

elsassph commented 2 years ago

@clarkjones indeed there was a subtle change in yargs-parser tokenization (for the better). It should be fixed now.

clarkjones commented 2 years ago

ok, works for me now. thanks