search

jasonphillips / draft-js-richbuttons-plugin

A plugin for adding rich formatting controls - https://jasonphillips.github.io/draft-js-richbuttons-plugin/
38 stars 14 forks source link

"getEditorState" is not a function (newer draft-js and draft-js-plugins-editor versions) #13

Open djackson1 opened 3 years ago

djackson1 commented 3 years ago

Hey @jasonphillips, not sure if you're still around or open to working on this.

I've been using draft-js, draft-js-plugins-editor and draft-js-richbuttons-plugin for some time in my personal project and had recently decided to upgrade some versions, notably:

draft-js version from 0.10.x to 0.11.x. and also draft-js-plugins-editor to 3.0.0 (or even 2.2.x)

My issue is that the function signature for handleKeyCommand has changed and now requires a "dummy arg" (I've tested this locally and it seems to allow the plugin to continue working)

Would I be able to make a PR to make this work on newer draft-js/plugins-editor versions?

Thanks

emilia-friedberg commented 3 years ago

I made a PR to this effect here: https://github.com/jasonphillips/draft-js-richbuttons-plugin/pull/14.