search

jasonplatts / nova-todo

A Panic Nova extension for todo and fixme management.
https://extensions.panic.com/extensions/jasonplatts/jasonplatts.TODO/
MIT License
29 stars 7 forks source link

Refine header command icons #40

Closed peteschaffner closed 1 year ago

peteschaffner commented 1 year ago

This PR:

  1. Makes the header command icons match the [subtler] color of other built-in "header" buttons, like the nav buttons in "Files" and "Remote":
CleanShot 2023-01-11 at 11 24 48@2x CleanShot 2023-01-11 at 11 23 46@2x CleanShot 2023-01-11 at 11 24 38@2x CleanShot 2023-01-11 at 11 24 04@2x

  1. Reduces the scale of the refresh icon so that it fit better (visually) within the bounds of the buttons:

    CleanShot 2023-01-11 at 11 28 37@2x

  2. Tweaks the scale and shape of the group icon to match more stylistically that of the refresh (and other built-in icons).

  3. Lastly, I updated the corresponding canvas names in Icons.sketch to make it easier to export (creating the required folder automatically).

These changes, unfortunately, fly in the face of similar header command buttons (e.g. the built-in "Debug"), so it does create some stylistic discrepancies:

CleanShot 2023-01-11 at 11 31 39@2x

That being said, I think it looks better visually :)

(It might actually be worth suggesting said scale and color changes to Panic so that using built-in images in this context produces a better result.)

jasonplatts commented 1 year ago

I totally agree. Looks great Pete! Thanks. This has been added in v3.1.2.