jasonpriem / HumanNameParser.php

Returns the parts (leading initial, first, middle, last, suffix) of a name from a string.
MIT License
108 stars 42 forks source link

Other common name combinations #6

Open keinstein opened 10 years ago

keinstein commented 10 years ago

Hi, your test case does not include common writings like Чайковский В. Н. Чайковский ВН which are used without colon in russian language.

Maybe you should explicitely warn that certain asian languages write names without colon in the opposite order to English which is hard to detect. Similarly, the German naming tradition has no strict order so the categories first name and middle name do not apply. In that tradition there exist only given names and an arbitrary nonempty subset of them was marked as calling names (comparible to the first name in USA or Russia) the others are treated like middle names in the USA, while they are freely chosen by the parents.

jasonpriem commented 10 years ago

Excellent points, thanks! Very educational...I had no idea about any of those cases. And I'm confident that even this list isn't complete...there are quite a few naming traditions and practices globally, to put it lightly.

Alas I think taking on any new cases is beyond me right now...no time. Do feel free to add some tests, the code to solve 'em, and submit a pull request, though!