fix: issue #19 always return browser to pool

jasonraimondi / url-to-png

Selfhosted. URL to PNG utility featuring parallel rendering using Playwright for screenshots and with storage caching via Local, S3, or CouchDB

https://jasonraimondi.github.io/url-to-png/

MIT License

156 stars 28 forks source link

fix: issue #19 always return browser to pool #20

Closed saschwarz closed 2 years ago

saschwarz commented 2 years ago

I wrapped the lifetime of the acquired browser from the browserPool in a try/finally so if any error occurs the browser is returned to the browserPool.

Following the README I couldn't get the code to compile using npm to pull down the packages/build. I noticed the git logs mentioned pnpm so tried that and everything compiled/ran and appears to work as before.