AWS environment variables names

jasonraimondi / url-to-png

Selfhosted. URL to PNG utility featuring parallel rendering using Playwright for screenshots and with storage caching via Local, S3, or CouchDB

https://jasonraimondi.github.io/url-to-png/

MIT License

156 stars 28 forks source link

AWS environment variables names #29

Closed enstyled closed 6 months ago

enstyled commented 7 months ago

It would be great to follow the naming conventions for the AWS environment variables names, e.g.

AWS_ACCESS_KEY_ID instead of AWS_ACCESS_KEY AWS_SECRET_ACCESS_KEY instead of AWS_SECRET_KEY etc.

Many hosting services provide add-ons that will automatically inject the credentials and usually follow these naming conventions.

Additionally, adding support for AWS_ENDPOINT_URL_S3 would be useful, in order to use S3-compatible services, such as Cloudlfare R2, Backblaze B2, Tigris.

jasonraimondi commented 7 months ago

I'd be happy to support this as long as there is backwards compatibility built in. If you submit a PR I would be happy to merge.

enstyled commented 6 months ago

Thank you for improving this and even adding the endpoint option! ❤️

jasonraimondi commented 6 months ago

Happy to 😁 thanks for the suggestion.