[#417] Add support for sending/receiving binary websocket messages

jasonrbriggs / stomp.py

“stomp.py” is a Python client library for accessing messaging servers (such as ActiveMQ or RabbitMQ) using the STOMP protocol (versions 1.0, 1.1 and 1.2). It can also be run as a standalone, command-line client for testing.

Apache License 2.0

491 stars 167 forks source link

[#417] Add support for sending/receiving binary websocket messages #419

Closed christopherjameshoward closed 1 year ago

christopherjameshoward commented 1 year ago

Adds support for the sending and receiving of binary websocket messages.

There are two aspects to the fix:

A new binary_mode boolean argument has been added to WSStompConnection (defaulting to False). If set to True, then all websocket messages will be sent as binary (opcode 0x2), rather than as text (opcode 0x1)
There was an assumption that all messages received were encoded as text and could be safely converted to bytes.

christopherjameshoward commented 1 year ago

https://github.com/jasonrbriggs/stomp.py/pull/422 has fixed one aspect of this (the receiving of binary messages) in a different way. However, that PR is still decoding and then re-encoding the data, which I would argue is unnecessary.

Also, that PR doesn't handle sending of binary messages.