jasonrogena / php-excel-reader

Automatically exported from code.google.com/p/php-excel-reader
1 stars 0 forks source link

when you set borders around fusioned cells in excel they are not displayed correctly by the dump function #33

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Version used : 2.21

when you drow borders around cells that are fusioned in
excel, they are not displayed as it should.
Sample step to reproduce : in excel, take a rectangle of 2x3 cells,
write a text in this fusion, set a border around this fusion.

Solution (the number on the left is the line number in
excel_reader2.php) :
445:    // Borders
446:    $bLeft = $this->borderLeft($row,$col,$sheet);
447:    $bRight = $this->borderRight($row,$col,$sheet);
448:    $bTop = $this->borderTop($row,$col,$sheet);
449:    $bBottom = $this->borderBottom($row,$col,$sheet);
450:    $rowspan = $this->rowspan($row,$col,$sheet);
+       $colspan = $this->colspan($row,$col,$sheet);
+       if ($rowspan>1) { $bBottom=$this->borderBottom($row+$rowspan-1,$col+
$colspan-1,$sheet); }
+       if ($colspan>1) { $bRight=$this->borderRight($row+$rowspan-1,$col+
$colspan-1,$sheet); }
451:    $bLeftCol = $this->borderLeftColor($row,$col,$sheet);
452:    $bRightCol = $this->borderRightColor($row,$col,$sheet);
453:    $bTopCol = $this->borderTopColor($row,$col,$sheet);
454:    $bBottomCol = $this->borderBottomColor($row,$col,$sheet); 

Original issue reported on code.google.com by wilfrid....@gmail.com on 8 Jul 2009 at 10:36