search

jasonrudolph / keyboard

⌨ Toward a more useful keyboard
MIT License
2.08k stars 211 forks source link

Escape sent after control+click #50

Closed bkeepers closed 5 years ago

bkeepers commented 5 years ago

control+click on a Mac will bring up the right click menu. Since https://github.com/jasonrudolph/keyboard/commit/c0e915b8ab8dd5586092495e5a78a9127d227a73, escape is sent when releasing the control key, regardless of how long control was held for, which will close any menu that comes up.

Expected behavior:

Escape key is only sent if control is quickly tapped and released.

Steps to reproduce:

  1. control+click on this page
  2. Release control once the menu appears
  3. See menu disappear

Checking out c0e915b8^ will revert to the expected behavior.

cc @landongrindheim

landongrindheim commented 5 years ago

Thanks for the heads up @bkeepers! Looks like I introduced a naming conflict in that commit 😓. #51 has been opened to fix this 😄