Fix issue detecting dropdown types

jasonsalzman / react-add-to-calendar

A simple, customizable, and reusable Add to Calendar button component for React

https://jasonsalzman.github.io/react-add-to-calendar/

MIT License

181 stars 123 forks source link

Fix issue detecting dropdown types #1

Closed joewoodhouse closed 7 years ago

joewoodhouse commented 7 years ago

In the current code, what gets sent to helpers.buildUrl is an array of 1 item (the keys of the current list item) when it should be a string - the one (any only) key.

The effect this has at the moment is that all links are downloading as .ics files, and the google and yahoo are not working as they should. With this fix, they are now working for me. Hopefully you can merge this asap :)

codecov-io commented 7 years ago

Current coverage is 88.76% (diff: 100%)

Merging #1 into master will increase coverage by 24.71%

@@             master         #1   diff @@
==========================================
  Files             2          2          
  Lines            89         89          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits             57         79    +22   
+ Misses           32         10    -22   
  Partials          0          0

Powered by Codecov. Last update f657a33...767f1ae

jasonsalzman commented 7 years ago

Good catch. Looks good.

joewoodhouse commented 7 years ago

Cool thanks. Would appreciate if you could npm publish that