search

jasonsalzman / react-add-to-calendar

A simple, customizable, and reusable Add to Calendar button component for React
https://jasonsalzman.github.io/react-add-to-calendar/
MIT License
180 stars 124 forks source link

Yahoo endTime appears to be parsed incorrectly #30

Open websmith opened 6 years ago

websmith commented 6 years ago

When viewing the yahoo.com calendar event, the endTime does not match what was provided in the prop object.

I'm seeing this on my own applications as well as the demo app provided by the author: https://jasonsalzman.github.io/react-add-to-calendar/

Example:

On the authors example application, clicking the button under the Examples Section, subsection "default", then selecting Yahoo. This will open the event in the yahoo.com calendar with the end time of 9/16/16 @ 8pm. However, the date provided to the prop was 9/16/16 @ 9:45pm.

authors example:

react_add_to_calendar_button_crafted_by_jason_salzman

yahoo calendar:

yahoo__calendar__july_2018
reergymerej commented 4 years ago

https://github.com/jasonsalzman/react-add-to-calendar/blob/master/src/helpers/index.js#L50-L55

This is not currently true. et can be used for end time (and should be for events over 100 hours).

There are other issues with end times not respecting timezones. For consideration, though, all/multi-day events can omit the time and TZ and create a mult-day span correctly with something like this.

https://calendar.yahoo.com/?v=60&view=d&type=20&title=foo&desc=bar&st=20200515&et=20200829