search

jasonsalzman / react-add-to-calendar

A simple, customizable, and reusable Add to Calendar button component for React
https://jasonsalzman.github.io/react-add-to-calendar/
MIT License
181 stars 123 forks source link

Remove moment dependency #5

Closed nickhudkins closed 3 years ago

nickhudkins commented 7 years ago

I know that if you're dealing with dates, you probably are going to be using moment so this may be super silly, but... perhaps others can "bring their own" date library by exposing a "calculateDuration" prop or something like that.

I'm going to be doing it for myself since I am using 'fecha' instead of moment, so in a bit you'll have a PR that you can reject or accept! (I'll make sure it works with moment still too)

jasonsalzman commented 7 years ago

So sorry for the delayed response. Did you ever push your PR? I never saw anything come through.

nickhudkins commented 7 years ago

Ah sorry about that! I have everything locally. I'll get it pushed tomorrow! On Tue, Feb 21, 2017 at 8:44 PM Jason Salzman notifications@github.com wrote:

So sorry for the delayed response. Did you ever push your PR? I never saw anything come through.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jasonsalzman/react-add-to-calendar/issues/5#issuecomment-281541532, or mute the thread https://github.com/notifications/unsubscribe-auth/AASQdsPwQ_-7sw-xpLFdjyKPeMp_uGhtks5re5LkgaJpZM4L9yxi .

mienaikoe commented 6 years ago

Did this PR ever get merged?

nickhudkins commented 3 years ago

It certainly doesn't appear like it did. I am not actively using this project and am a bit too far removed at this point to move this forward :(