search

jasonsalzman / react-add-to-calendar

A simple, customizable, and reusable Add to Calendar button component for React
https://jasonsalzman.github.io/react-add-to-calendar/
MIT License
181 stars 123 forks source link

Dropdown not getting trigged on button click with React/ReactDOM versions 17+ #65

Open amamenko opened 3 years ago

amamenko commented 3 years ago

The AddToCalendar component is not opening on button click for React and ReactDOM versions past 17.0.0. The click event is still being registered but the actual dropdown is not being toggled.

Keep in mind, I have also tried to activate the dropdown by holding its "open" configuration via state and manipulating the component's optionsOpen prop to no avail. Mounting separate AddToCalendar components with true/false optionsOpen props based on state has not worked, either.

The most recent React/ReactDOM version to work with this package at this point appears to be 16.14.0.

marrkeri commented 3 years ago

same here

jonmifsud commented 3 years ago

Refer to #62 for a fix

marrkeri commented 3 years ago

I don't believe this will be merged soon. There are PRs since 2018 :(

I have already switched to different package because can't wait - for the others you can try @culturehq/add-to-calendar https://www.npmjs.com/package/@culturehq/add-to-calendar

Pretty similar and easy to use.

esetnik commented 3 years ago

@jasonsalzman i would be willing to maintain this project and get some PRs merged if you'd like help.

haveaguess commented 3 years ago

@jasonsalzman want to use this but seems like you aren't letting people keep it alive? :/

@esetnik maybe someone will have to fork it and take it forward?

esetnik commented 3 years ago

@haveaguess I switched to https://www.npmjs.com/package/@culturehq/add-to-calendar 😞

haveaguess commented 3 years ago

Thanks, took a look but seems a shame as this has a bunch of unit tests (not many I admit) and props that other project doesn't so would end up having to wait for that to mature.

There are 1.2k people using this and a bunch of decent PRs waiting for be merged.

On Tue, Feb 2, 2021 at 3:50 PM Ethan Setnik notifications@github.com wrote:

@haveaguess https://github.com/haveaguess I switched to https://www.npmjs.com/package/@culturehq/add-to-calendar 😞

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jasonsalzman/react-add-to-calendar/issues/65#issuecomment-771731934, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAU6PP2LDKZ4FXMKX3RV3DS5ANLTANCNFSM4UNZ3P7A .

esetnik commented 3 years ago

@haveaguess beware of #61. I had to change to @culturehq/add-to-calendar due to this bug.

haveaguess commented 3 years ago

Oh ok, painful, any PRs waiting for that? Maybe I can just merge them in? 😔

akdsco commented 3 years ago

@jasonsalzman help 🙏 otherwise @haveaguess will have many sleepless nights and his boi won't have a dad for few days 😬😬

esetnik commented 3 years ago

Oh ok, painful, any PRs waiting for that? Maybe I can just merge them in? 😔

I didn't figure out the issue, but it's working in @culturehq/add-to-calendar so I guess whatever they are doing could be backported to this repo.

haveaguess commented 3 years ago

Ics file downloaded for me in chrome when clicking Outlook button but outlook.com has a time format bug that I can see was fixed in @culturehq/add-to-calendar in 2020

I'm thinking I'll probably fork and take this repo forward, would you be interested in helping maintain?

On Wed, Feb 3, 2021 at 3:55 PM Ethan Setnik notifications@github.com wrote:

Oh ok, painful, any PRs waiting for that? Maybe I can just merge them in? 😔

I didn't figure out the issue, but it's working in @culturehq/add-to-calendar so I guess whatever they are doing could be backported to this repo.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jasonsalzman/react-add-to-calendar/issues/65#issuecomment-772614385, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAU6PO7MC67BLGHUUPMPSLS5FWYZANCNFSM4UNZ3P7A .

esetnik commented 3 years ago

Ics file downloaded for me in chrome when clicking Outlook button but outlook.com has a time format bug that I can see was fixed in @culturehq/add-to-calendar in 2020

@haveaguess ok. It didn't work for me in chrome or safari using this package.

I'm thinking I'll probably fork and take this repo forward, would you be interested in helping maintain?

Sorry, can't commit to it as we no longer use it.

haveaguess commented 3 years ago

Ics file downloaded for me in chrome when clicking Outlook button but outlook.com has a time format bug that I can see was fixed in @culturehq/add-to-calendar in 2020

@haveaguess ok. It didn't work for me in chrome or safari using this package.

I'm thinking I'll probably fork and take this repo forward, would you be interested in helping maintain?

Sorry, can't commit to it as we no longer use it.

We ended up moving to

https://www.npmjs.com/package/@culturehq/add-to-calendar

..and forking it to build in multi-line HTML support for descriptions, HTML in ICS, and recipient pre-population for google/outlook :

https://github.com/connect4app/add-to-calendar

It's pretty rough at the moment but we hope to find time to clean it up and PR some changes back in