search

jasonslyvia / react-marquee

A <marquee> component for React
81 stars 33 forks source link

Reset Offset on Text Change #9

Closed sahilchaddha closed 7 years ago

sahilchaddha commented 7 years ago

Fixed an Issue of Offset not being resetting on Text Change. Steps to Reproduce : 1.Set a large text and let it Scroll. 2.Change the Text

Actual Result : The Offset of Marquee Label is not reset to 0. Expected Result : Offset should be reset to 0.

Added Check for Text Length Changed & Reset offset in WillRecieveProps()

jasonslyvia commented 7 years ago

awesome, thanks @sahilchaddha !

jasonslyvia commented 7 years ago

Hi, I published version react-marquee@0.1.1 regarding this PR in case you need it.

sahilchaddha commented 7 years ago

@jasonslyvia Thank you :)