johnkahn commented 5 years ago

Background

I usually break up my lists by priority, and think it would help to see it broken down by priority.

Let me know if you want anything changed, or if this isn't something you want added. Thanks! 👍

Changes

When there are multiple priorities, they are shown under the total amount sorted by their amounts.

I had to change the hash function to take them into account, and I used the priority labels for the hash.

jasontbradshaw commented 5 years ago

Thanks for your contribution; it's always nice to see that you're not the only person who cares about something!

It might take me a few days to get the time to look over this thoroughly, just to set your expectations.

Here are my first thoughts after glancing at it, so you have something to chew on while I circle back around:

How does this look on mobile? This extension works on Firefox for Android, and I'm afraid that with the extra totals it might take up a disproportionately-large portion of the screen there.
There doesn't seem to be a way to turn it off. The extension currently lacks a "settings" page, which I've considered adding in the past and would be a perfect place for something like this. However, adding a "settings" page is a much larger task that I've punted on for quite a while since I've never really had a need for one. A compromise might be to allow it to be default-hidden behind a link/button of some sort that toggles it, and persist the "open/closed" state to localStorage so you don't have to toggle it manually for every list.

Thanks again!

johnkahn commented 5 years ago

Thanks for looking at it!

I'll check on mobile and make some updates to make sure it looks good.
I like the idea of persisting a state to localStorage and toggling it with a button, I'll try some different options and post them here

jasontbradshaw commented 4 years ago

Closing this since it's been almost a year with no updates.