jasonusa / webgrind

Automatically exported from code.google.com/p/webgrind
Other
0 stars 0 forks source link

xdebugOutputFormat regexp is too restrictive #14

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
the current outputname is determined as follows:
$outputName = '/^'.preg_replace('/(%[^%])+/', '[a-zA-Z0-9%_-~=]+',
$outputName).'$/';

However; this is far too restrictive; my xdebug.profiler_output_name is set
to 'profile.%R'; which means that the filename can include all characters
that are allowed in a URL; such as ~ and =. I suggest changing the match to
simply .

Original issue reported on code.google.com by Sjon.Hor...@gmail.com on 9 Jul 2008 at 10:11

GoogleCodeExporter commented 8 years ago
Changed in r126

Original comment by gugakf...@gmail.com on 17 Jul 2008 at 10:57

GoogleCodeExporter commented 8 years ago
Now to permissive. It makes the preprocessed data files appear in the trace 
list. It should specifically exclude 
.webgrind files. Alternatively we could change prepend the preprocessed files 
with something.

Original comment by oett...@gmail.com on 18 Jul 2008 at 10:13

GoogleCodeExporter commented 8 years ago
That's odd, it works for me. 

Changing from `[a-zA-Z0-9%_-~=]+` to `.+` shouldn't have any effect on whether 
.webgrind files are 
included...

Are you looking into this?

Original comment by gugakf...@gmail.com on 18 Jul 2008 at 3:33

GoogleCodeExporter commented 8 years ago
Obviously the .webgrind files are included because dots are now allowed in the 
filename. Never occured to me 
because my storageDir was in fact different from the xdebug storagedir. 

Fixed in r130

Original comment by gugakf...@gmail.com on 1 Aug 2008 at 9:40