jasonusa / webgrind

Automatically exported from code.google.com/p/webgrind
Other
0 stars 0 forks source link

config.php xdebug_output_name buglets #23

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Use ...%R.%s... in xdebug.profiler_output_name on Windows
2. Name a directory something like 'example.com'
3.

What is the expected output? What do you see instead?
Expected to see files such as:
cachegrind.out..example.com/index.php.###_### in popup.

%R is "not working" for me.  Posted to xdebug-general, but for now...

No such files were there.

What version of the product are you using? On what operating system?
Everything current on xdebug/webgrind/xdebug-helper
Windows XP sp 2.

Please provide any additional information below.
Patch:
--- config.php.original 2008-07-23 11:36:10.103817300 -0500
+++ config.php  2008-07-23 11:35:27.885067300 -0500
@@ -53,7 +53,8 @@
                if($outputName=='') // Ini value not defined
                        $outputName = '/^cachegrind\.out\.[0-9]+$/';
                else
-               $outputName = '/^'.preg_replace('/(%[^%])+/',
'[a-zA-Z0-9%_-]+', $outputName).'$/';
+               $outputName = '/^'.preg_replace('/(%[^%])+/',
'[a-zA-Z0-9%_.-]*', $outputName).'$/';
            return $outputName;
     }

Feel free to accept ONLY the change from + to * or ONLY the addition of '.'
in the replacement character set.

I guess I should have made it two different patches, since it's two
different issues, technically...

Sorry.

Hey, at least I'm providing patches, eh?

Original issue reported on code.google.com by richardl...@gmail.com on 23 Jul 2008 at 4:41

GoogleCodeExporter commented 8 years ago
Yikes!

I had an error_log in there, and ripped it out of the patch, and now it's 
probably
"off" in the line numbers.

Sorry.

Silly mistake.

REAL patch here:

--- config.php.original 2008-07-23 11:36:10.103817300 -0500
+++ config.php  2008-07-23 11:43:34.056942300 -0500
@@ -53,7 +53,7 @@
                if($outputName=='') // Ini value not defined
                        $outputName = '/^cachegrind\.out\.[0-9]+$/';
                else
-               $outputName = '/^'.preg_replace('/(%[^%])+/', '[a-zA-Z0-9%_-]+',
$outputName).'$/';
+               $outputName = '/^'.preg_replace('/(%[^%])+/', 
'[a-zA-Z0-9%_.-]*',
$outputName).'$/';
            return $outputName;
     }

Original comment by richardl...@gmail.com on 23 Jul 2008 at 4:44

GoogleCodeExporter commented 8 years ago
There seems to be an issue where the profile file is not saved with the 
xdebug.profiler_output_name specified in 
the php.ini file. On my machine this happens when profiling a subdir on 
localhost. 

Only the static part and the pid (%p) will be included in these cases. This is 
related to xdebug itself and not 
directly to webgrind. 

Original comment by gugakf...@gmail.com on 1 Aug 2008 at 10:14