jasonw4331 / MyPlot

Plot and protection plugin for PocketMine-MP
https://discord.gg/Qqcpp9Q
MIT License
101 stars 90 forks source link

Feature Request: API Extending for Plot bounding boxes and more #107

Closed inxomnyaa closed 6 years ago

inxomnyaa commented 7 years ago

Optional information

I am working on extending MyPlot to have API commands for plugins like MyPlot, but also to simplify some things. This issue is more of an announcement, but also a collection of things that MyPlot would need to add

It is planned to add:

jasonw4331 commented 7 years ago

This would be better placed in MyPlot Addons. I don't want other plugin involvement which isn't tied to economy in MyPlot

inxomnyaa commented 7 years ago

I thought that would be visible out of the issue description, but here again:

MyPlot will get some extended API code for non-MyPlot plugins. These will include for example: Getting a proper size of plots (also when combined via plot combining plugin); Permission reading; Translations (might not all be in myplot directly); Probably a config setting

jasonw4331 commented 7 years ago

As I previously said, I don’t want non-economy plugin involvement. I will not add permissions or otherwise to MyPlot that do not pertain the the plugin itself. This would be better done through MyPlot Addons

inxomnyaa commented 7 years ago

As i previousely said: I WILL have to extend MyPlot's API with maybe 2 functions.

HimbeersaftLP commented 7 years ago

I don't want other plugin involvement which isn't tied to economy in MyPlot

Why though?

inxomnyaa commented 7 years ago

@HimbeersaftLP it makes sense to not wanting to include stuff by other plugins. If they malfunction, the people most likely comment in this issue tracker etc

jasonw4331 commented 7 years ago

MyPlot is based on PlotMe, so I want to keep the plugin's features to be as close as I can get it too. ithttp://plotme.worldcretornica.com/

jasonw4331 commented 7 years ago

@thebigsmileXD if you want to use MagicWE with MyPlot, then do like Sandertv did. Don't update MyPlot to use the plugin. Update the Plugin to use MyPlot.

inxomnyaa commented 7 years ago

image

jasonw4331 commented 7 years ago

What are you defining Plot bounding boxes as?

inxomnyaa commented 7 years ago

API::getPlotBB():AxisAlignedBB -> must work with connected plots, so maybe events etc etc. Streets too.

Good things:

jasonw4331 commented 7 years ago

Plots don't have bounding boxes though because they are not entities or singular blocks

inxomnyaa commented 7 years ago

http://memedad.com/meme/172636

HimbeersaftLP commented 7 years ago

MyPlot is based on PlotMe, so I want to keep the plugin's features to be as close as I can get it too.

Does adding more API make it worse though? No

jasonw4331 commented 7 years ago

Not necessarily. I want to keep the features as close as possible, but I never looked at the code for PlotMe, so I am doing the API as it's needed. I want the features to match, but the code can be slightly different. MagicWE can be modified to work with MyPlot, not the other way around. That's my final say on this

inxomnyaa commented 7 years ago

This is exactly what i said before.

What me and @HimbeersaftLP mean: Why would you not add more API methods for plugins, so coding based on MyPlot is easier?

See the #61 PR

Sandertv commented 7 years ago

Even though it would be a fair idea to add some functions like getMaxX() in plots, it really isn't something mandatory to add. It's very easy to build on My plot with the current API as well. Adding functions like getMinX() will be useful when plots are able to be merged, but that's a next step nobody should currently be bothered about. (in my opinion, yours could be different)

jasonw4331 commented 6 years ago

AABBs were added. Permissions will not be added to MyPlot for MagicWE. MagicWE can be modified to work with MyPlot, not the other way around

inxomnyaa commented 6 years ago

I stopped supporting outdated plugins