jasonw4331 / MyPlot

Plot and protection plugin for PocketMine-MP
https://discord.gg/Qqcpp9Q
MIT License
101 stars 90 forks source link

Remove non-vanilla * from helper and denial systems #336

Open jasonw4331 opened 4 years ago

jasonw4331 commented 4 years ago

Introduction

Recently it was pointed out to me that @a would be better to be used in place of the asterisk * because Vanilla bedrock edition uses the @a selector. I agree.

The plugin PlayerSelectors on poggit can be used to add the @a selector along with many other vanilla selectors. This PR removes the * implementation in a push for users to use the PlayerSelectors plugin instead.

Relevant issues

Changes

API changes

Behavioral changes

Backwards compatibility

Follow-up

Tests

The asterisk* no longer functions to allow or block all players.

Thunder33345 commented 4 years ago

The addhelper subcommand can no longer use the asterisk to open a plot to everyone The denyplayer subcommand can no longer use the asterisk to block everyone from a plot

what's a valid new replacement or an alternative for a wildcard allow/block? assuming @a only applies to currently online players