search

jasonwhite / rudolfs

A high-performance, caching Git LFS server with an AWS S3 and local storage back-end.
MIT License
392 stars 39 forks source link

Dependency update #46

Closed daniel-noland closed 2 years ago

daniel-noland commented 2 years ago

I bumped the dependencies to current everywhere I could find something out of date.

I didn't notice any regressions in this patch series although some minor refactoring was required.

I left the series as distinct, easily reverted patches in case something goes wrong. Let me know if you want me to squash them.

jasonwhite commented 2 years ago

FYI, I fixed the clippy lint errors in the main branch.

daniel-noland commented 2 years ago

FYI, I fixed the clippy lint errors in the main branch.

I rebased onto master so clippy warnings should not bounce me in CI this time.

Thanks for sorting them :)

daniel-noland commented 2 years ago

one note vs prior version of this PR:

I didn't even see the faulty feature when I did the prior batch of updates.

As a result my changes introduced several regressions I didn't catch on that code base.

I cleaned them up in the second to final commit in this series. That commit is worth review at your convenience.

If you want me to move that to a different patch series that's fine.

Alternatively I can re-structure the patch series to make sure faulty doesn't regress as we walk the updates. As this series stands there are commits in the tree where faulty won't build