search

jasonwilliams / anki

Anki VSCode Plugin
MIT License
275 stars 31 forks source link

Fixed deck name pulling more than just the header #25

Closed a-guy-on-the-internet closed 3 years ago

a-guy-on-the-internet commented 3 years ago

Fix for issue #24

a-guy-on-the-internet commented 3 years ago

Tell me if you want me to do anything extra

jasonwilliams commented 3 years ago

Thanks @MicahGV A test would be good, similar to what I did here https://github.com/jasonwilliams/anki/blob/master/src/markdown/parsers/__tests__/cardParser.test.ts

a-guy-on-the-internet commented 3 years ago

Sure man

a-guy-on-the-internet commented 3 years ago

I ended up adding some additional linter config so when I created new files I wouldn't have to care about swapping it over from my default. Also, I hope it's alright if I only focused on the deckName method for the tests.

jasonwilliams commented 3 years ago

@MicahGV this is fantastic, those tests are awesome. Thanks!

Also, I hope it's alright if I only focused on the deckName method for the tests.

Yes this is no problem