jasonwilliams / anki

Anki VSCode Plugin
MIT License
273 stars 31 forks source link

Fix some bugs (Mainly string parsing) #79

Closed duguosheng closed 1 year ago

duguosheng commented 2 years ago
  1. LaTeX curly brackets do not convert correctly #63
  2. a display error: when user sets the saveStrategy to useDirStructure, the actual deck does not match the displayed deck when executing the Send To Deck command
  3. update docs
duguosheng commented 2 years ago

md file like this:

## test

$a=\{1,2\}$
$b=\#1$ 
$c=\&1$ 
$d=\_1$
$e=\$1$
$f=\%100$ 

before:

image

now:

image
duguosheng commented 2 years ago

now, line feed can be sent correctly to anki, but seems like that anki doesn't support it.

image
duguosheng commented 2 years ago

now, content like this can be sent correctly.

$$
\begin{align}
P ::&= P \\
    &|\ \neg P \\
    &|\ \top \\
    &|\ \bot \\
    &|\ P\backslash /P \\
    &|\ P/\backslash P
\end{align}
$$

before:

image

now:

image
duguosheng commented 2 years ago

add some tests for this.

jasonwilliams commented 2 years ago

add some tests for this.

Thanks!!

duguosheng commented 2 years ago

But these tests don't seem very intuitive, because they can't show the final effect. I posted some screenshots in the comments above:)

jasonwilliams commented 2 years ago

But these tests don't seem very intuitive, because they can't show the final effect. I posted some screenshots in the comments above:)

What do you think we should do in this case? Should we keep them and use them as a quick sanity check or have a better way to test this? Its a very "visual" thing so i don't know of a better way to test it is working properly

duguosheng commented 2 years ago

I've updated the test of latex conversion, maybe this could be better.

duguosheng commented 1 year ago

fix: Send to DirName just creates a deck called 'deck/subdeck' #80

jasonwilliams commented 1 year ago

LGTM