search

jasonwilliams / anki

Anki VSCode Plugin
MIT License
273 stars 31 forks source link

Adding embeddable cards in a backward compatible way. #91

Open vavdoshka opened 1 year ago

vavdoshka commented 1 year ago

Added embeddable cards in a backward-compatible way. Allows limiting the scope of the processing to the content between <!-- BEGIN_ANKI_CARDS --> and <!-- END_ANKI_CARDS --> comments.

I found it helpful to embed the Anki Cards definitions into documents with some knowledge base data. This change is backward compatible and should work with all the existing features from how far I've tested.

jasonwilliams commented 1 year ago

Hey @vavdoshka thanks for this PR, looks good. I’ll try and take a proper look

vavdoshka commented 1 year ago

I just updated the logic slightly.

jasonwilliams commented 1 year ago

Hey @vavdoshka, Implementation looks good, it may be worth adding a test here or here

jasonwilliams commented 1 year ago

Pings @vavdoshka are you still active on this?