jasonwilliams / vscode-helix

MIT License
178 stars 9 forks source link

feat: configuration settings #26

Open Armando-CodeCafe opened 7 months ago

Armando-CodeCafe commented 7 months ago

Request to allow for some additional configuration of the plugin. things like being able to add color switching to the status bar so every mode has a different color, or change the name of the modes. also how the insert modes work. for example currently the insert mode and append keys both do the same thing and when exited will move one key stroke backwards.

jasonwilliams commented 6 months ago

Hey thanks, the color switching sounds reasonable. The mode changes I'm less understanding off, what would you have preferred to change them to?

Also would you be up for contributing this change? It should be straight forward.

Armando-CodeCafe commented 6 months ago

Hi, for example in the real helix config there is an option to change the wording for every mode. Forexample: Normal or NORMAL instead of NOR, and VISUAL instead of select or sel, etc.

Ive never worked on visual studio code extensions but i could give it a shot, what would be the process for modifying the statusbar and add a configuration for it?

Sent from Outlook for Androidhttps://aka.ms/AAb9ysg


From: Jason Williams @.> Sent: Monday, April 15, 2024 10:12:42 AM To: jasonwilliams/vscode-helix @.> Cc: Armando Roerdinkveldboom @.>; Author @.> Subject: Re: [jasonwilliams/vscode-helix] feat: configuration settings (Issue #26)

Hey thanks, the color switching sounds reasonable. The mode changes I'm less understanding off, what would you have preferred to change them to?

Also would you be up for contributing this change? It should be straight forward.

— Reply to this email directly, view it on GitHubhttps://github.com/jasonwilliams/vscode-helix/issues/26#issuecomment-2056084747, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A4EG66BRZW4BMPLJVEPUC6TY5ODXVAVCNFSM6AAAAABGDRHYBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJWGA4DINZUG4. You are receiving this because you authored the thread.Message ID: @.***>

jasonwilliams commented 6 months ago

Hey @Armando-CodeCafe most of the logic is here: https://github.com/jasonwilliams/vscode-helix/blob/main/src/statusBar.ts#L68-L95

Your best bet is:

The colors were coming from here: https://code.visualstudio.com/api/references/theme-color

Armando-CodeCafe commented 6 months ago

Neat stuff, and how would i link that to a configuration option for the extension? One that the user can easily edit and view from the extensions window

Sent from Outlook for Androidhttps://aka.ms/AAb9ysg


From: Jason Williams @.> Sent: Thursday, April 18, 2024 10:25:23 PM To: jasonwilliams/vscode-helix @.> Cc: Armando Roerdinkveldboom @.>; Mention @.> Subject: Re: [jasonwilliams/vscode-helix] feat: configuration settings (Issue #26)

Hey @Armando-CodeCafehttps://github.com/Armando-CodeCafe most of the logic is here: https://github.com/jasonwilliams/vscode-helix/blob/main/src/statusBar.ts#L68-L95

Your best bet is cloning this repo, hitting debug in VSCode then setting breakpoints there and changing the colorshttps://github.com/jasonwilliams/vscode-helix/blob/main/src/statusBar.ts#L11.

The colors were coming from here: https://code.visualstudio.com/api/references/theme-color

— Reply to this email directly, view it on GitHubhttps://github.com/jasonwilliams/vscode-helix/issues/26#issuecomment-2065244143, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A4EG66FOQ7EQX46XDN4HQ2DY6AT3HAVCNFSM6AAAAABGDRHYBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRVGI2DIMJUGM. You are receiving this because you were mentioned.Message ID: @.***>

jasonwilliams commented 6 months ago

Sorry I don't understand your question, what do you mean link that to a configuration option?

Maybe start basic, try just adding a basic config to the extension and we can go from there

Armando-CodeCafe commented 6 months ago

Thats my question, how do i create a config for it and link the config values to the status bar for example

Sent from Outlook for Androidhttps://aka.ms/AAb9ysg


From: Jason Williams @.> Sent: Saturday, April 20, 2024 1:06:05 PM To: jasonwilliams/vscode-helix @.> Cc: Armando Roerdinkveldboom @.>; Mention @.> Subject: Re: [jasonwilliams/vscode-helix] feat: configuration settings (Issue #26)

Sorry I don't understand your question, what do you mean link that to a configuration option?

Maybe start basic, try just adding a basic config to the extension and we can go from there

— Reply to this email directly, view it on GitHubhttps://github.com/jasonwilliams/vscode-helix/issues/26#issuecomment-2067639921, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A4EG66EPC5UMDR4QEWRHECLY6JDZ3AVCNFSM6AAAAABGDRHYBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRXGYZTSOJSGE. You are receiving this because you were mentioned.Message ID: @.***>

jasonwilliams commented 6 months ago

I see, have a look at this comment above, I link to an example project there where you can work it out https://github.com/jasonwilliams/vscode-helix/issues/26#issuecomment-2065244143

tmpm697 commented 5 months ago

@jasonwilliams so currently no way to load external config file, i have config in ~/.config/helix but it seems not load it.

jasonwilliams commented 5 months ago

@jasonwilliams so currently no way to load external config file, i have config in ~/.config/helix but it seems not load it.

Sadly not, I have forked the Vim Extension which does support reading config files but it may take a while to migrate that over to Helix config. Any contributions would be appreciated