search

jasp-stats / jasp-issues

This repository is solely meant for reporting of bugs, feature requests and other issues in JASP.
55 stars 29 forks source link

[Bug]: Logistic Regression Footnote message #1984

Open KelvinBalcombe opened 1 year ago

KelvinBalcombe commented 1 year ago

JASP Version

0.17.0

Commit ID

No response

JASP Module

Regression

What analysis are you seeing the problem on?

logistic regression

What OS are you seeing the problem on?

Windows 10

Bug Description

error message

Expected Behaviour

Using Firth Logistic Regression should not then create a footnote message when using logistic regression

Steps to Reproduce

  1. Call up the titanic data from the data library under regression
  2. Run a logistic regression of Survived on Age (this should work)
  3. Choose a Firth Logistic Regression from the Generalised Linear Model, and run the same model above (this should work)
  4. Now repeat a new version of step 2. Above the coefficients table there is a warning saying JASPTable$addFootnote ... that obscures the output

Log (if any)

None

Final Checklist

github-actions[bot] commented 1 year ago

@KelvinBalcombe, thanks for taking the time to create this issue. If possible (and applicable), please upload to the issue website (https://github.com/jasp-stats/jasp-issues/issues/1984) a screenshot showcasing the problem, and/or a compressed (zipped) .jasp file or the data file that causes the issue. If you would prefer not to make your data publicly available, you can send your file(s) directly to us, issues@jasp-stats.org

boutinb commented 1 year ago

A compressed (zipped) .jasp file of your issue would be more than welcome!

tomtomme commented 4 months ago

@boutinb & @KelvinBalcombe Kelvin provided a jasp file by pointing to the titanic data from our library. With this I can reproduce this indeed very weird error (on flatpak) that depends on the order of analysis you do. I attached the jasp file containing the analysis and the error message that were precisely given by Kelvin. Sorry for not following up earlier on this! Titanic.zip

@fqixiang Are you still working on jasp issues? If not I would try to reassign them.

fqixiang commented 4 months ago

Hi Thomas, I'm not atm. I would have some time in May/June, but that's probably too late.

Qixiang

On Thu, 8 Feb 2024 at 11:52, Thomas Langkamp @.***> wrote:

@fqixiang https://github.com/fqixiang Are you still working on jasp issues? If not I would try to reassign them.

— Reply to this email directly, view it on GitHub https://github.com/jasp-stats/jasp-issues/issues/1984#issuecomment-1933818002, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5Y37KKW57UJLOHFKXVM4DYSSU6LAVCNFSM6AAAAAAUKEL4OSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZTHAYTQMBQGI . You are receiving this because you were mentioned.Message ID: @.***>

fqixiang commented 4 months ago

@Thomas, let me have a look and unassign myself from those I don't think I will have time for.

On Thu, 8 Feb 2024 at 14:53, Thomas Langkamp @.***> wrote:

@fqixiang https://github.com/fqixiang Would you prefer to stay assigned to those issues then? Or do you want to see which ones you want to tackle, when you have time?

— Reply to this email directly, view it on GitHub https://github.com/jasp-stats/jasp-issues/issues/1984#issuecomment-1934168888, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5Y37OB6GGTFF5LGLJ2YWDYSTKENAVCNFSM6AAAAAAUKEL4OSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZUGE3DQOBYHA . You are receiving this because you were mentioned.Message ID: @.***>

tomtomme commented 1 month ago

tested and still valid for latest 0.19 beta

JorisGoosen commented 1 month ago

Really weird bug!

JorisGoosen commented 1 month ago

Somehow something gets stuck somewhere between 2 analyses running on the same engine but I have no idea where...

You can see by opening the engine-window (Ctrl/Cmd+Alt+Shift+E) en then killing it by pressing right/middle-mouse button. Rerunning the analysis then works.... Until you run the generalized one once more...

Definitely something strange going on and I would like to know what is going wrong here. But at least @JohnnyDoorn has a fix.

tomtomme commented 1 week ago

I tried verifiing that this one is fixed but it seems module logistic regression is now completely broken: grafik

-------- Application Info -------- JASP Version: JASP 0.19 Build Branch: HEAD Build Date: Jun 18 2024 13:07:48 (Netherlands) Last Commit: a6131f3f59ec89e1804870d99b73e0e63803d8d9

-------- Basic Info -------- Operating System: KDE Flatpak runtime Product Version: 6.7 Kernel Type: linux Kernel Version: 6.9.3-3-MANJARO Architecture: x86_64 Install Path: /app/bin Platfotm Name: wayland System Local: de_DE

JohnnyDoorn commented 1 week ago

Yes, this is now fixed, thanks for checking