jasp-stats / jasp-issues

This repository is solely meant for reporting of bugs, feature requests and other issues in JASP.
58 stars 29 forks source link

[Feature Request]: Name "Group 1" and "Group 2" according to entries #2232

Open dekuenstle opened 1 year ago

dekuenstle commented 1 year ago

Description

Name "Group 1" and "Group 2" in the interface according to the data

Purpose

Avoid mistakes in interpretation

Use-case

Change direction of tests in the interface

Is your feature request related to a problem?

No response

Is your feature request related to a JASP module?

Regression, T-Tests

Describe the solution you would like

the interface would replace the "Group 1" and "Group 2" placeholder with the actual name of the groups as provided in the data columns.

Describe alternatives that you have considered

Automatically show the description table, which provides these names

Additional context

Many analysis in JAGS provide options concerning "Group 1" and "Group 2", like t-Tests or correlations. These options are sometimes confusing and can easily lead to mistakes in the interpretation. Here it would be convenient, if the interface would replace the "Group 1" and "Group 2" placeholder with the actual name of the groups as provided in the data columns.

EJWagenmakers commented 1 year ago

I support this suggestion -- it is even confusing for me when I teach

Kucharssim commented 1 year ago

I agree it would be a good improvement. @boutinb, how hard is it to get factor levels from a column to fill in component titles dynamically in qml?

boutinb commented 1 year ago

Well.... I have tried, and I had to go quite far to get something working. If you have a VariablesList called splitBy, then this code sets the text Group 1 > Group 2, toGroup A > Group B, when the variable has A and B as labels. But it is really hacky... So I should add a feature so that it makes it easily possible.

    DropDown
    {
        id: test
        name: "test"
        source: [{name: "splitBy", use: "levels"}]
        visible: false
        property var groupValues: [1, 2]
    }

    Row
    {
        visible: false
        Repeater
        {
            model: test.model
            Text {text: test.model.data(test.model.index(index, 0)) }
            onItemAdded: (index, item) =>
                         {
                             var temp = test.groupValues
                             temp[index] = item.text
                             test.groupValues = temp
                         }
        }
    }

    Text { text: qsTr("Group %1 > Group %2").arg(test.groupValues[0]).arg(test.groupValues[1]) }
tomtomme commented 6 months ago

@dekuenstle @boutinb This seems fixed, right? Here for regression: image

Or are we talking about the t-Test interface: image

Then I do not see, how this is related to regression however...

boutinb commented 6 months ago

This is not yet implemented. I don't see that in the Regression module. It is well in the Summary Statistics module.