jasp-stats / jasp-issues

This repository is solely meant for reporting of bugs, feature requests and other issues in JASP.
59 stars 29 forks source link

[Bug]: Label filter not being applied, even though registering as ticked #2301

Closed fredcito closed 1 year ago

fredcito commented 1 year ago

JASP Version

0.18.0

Commit ID

No response

JASP Module

Other

What analysis are you seeing the problem on?

Filtering in spreadsheet view via label editor

What OS are you seeing the problem on?

macOS Silicon

Bug Description

When applying the filter to a label in spreadsheet view, an 'x' appears duly by a category, but is not excluded in the spreadsheet (not greyed out, and appearing in data). The excluded level can also be included in a statistical model.

image

Expected Behaviour

Filter should have excluded rows (it has worked well before this update)

Steps to Reproduce

  1. Closed all JASP engines, reopened, applied filter, same behavior

Log (if any)

JASP 2023-09-24 13_51_04 Desktop.log

Final Checklist

github-actions[bot] commented 1 year ago

@fredcito, thanks for taking the time to create this issue. If possible (and applicable), please upload to the issue website (https://github.com/jasp-stats/jasp-issues/issues/2301) a screenshot showcasing the problem, and/or a compressed (zipped) .jasp file or the data file that causes the issue. If you would prefer not to make your data publicly available, you can send your file(s) directly to us, issues@jasp-stats.org

JorisGoosen commented 1 year ago

@fredcito could you also upload the engine logs?

Is the data/jasp file shareable with us?

fredcito commented 1 year ago

Hi Joris,

thanks for getting in touch (and also to the whole team for the amazing work!).

This is a really weird bug, was just going to update the post; the same file has now started to work as it should. Unfortunately I did not increase the number of logs to keep, and the previous engine log has been deleted.

Can I keep track of this and see if it recurs?

On a rather different topic I've been talking with my colleague Henrik Singmann whose code is used for some of JASP, including the repeated measures ANOVA follow-up tests. He mentioned that the default was for a long time model = "univariate", but since version 1.0 (2021-07-02), the default is model = "multivariate" (but both still supported). He suggested that the better default for JASP current version would be "multivariate" if possible.

In any case, thank you again for your help, and sorry to not even be able to send a relevant log or reproducible error!

best Fred

JorisGoosen commented 1 year ago

Hey Fred,

No problem and you are welcome :)

Very weird bug indeed, maybe the engine was a bit slow or something? However, if you do manage to get this same problem to occur and can then also upload the engine logs we can have a look and see whats going on. If you manage to reproduce it feel free to reopen this issue.

As far as the default option for ANOVA RM goes, im sure there was a good reason to switch the default, right @JohnnyDoorn or @vandenman ?

Cheers, Joris

JohnnyDoorn commented 1 year ago

@fredcito thanks for the suggestion, I agree that we should change this default option (the option was implemented by me after my last chat with Henrik, about exactly this). The reason we have left it so far is to make the follow-up test results match those of SPSS (and therewith, popular statistics text-books), but I feel that we have outgrown this and can do our own thing now if we feel it makes statistical/methodological sense.

fredcito commented 1 year ago

Hi all thanks for this! And yes, let's hope that the era of SPSS hegemony is at an end ....

best Fred