search

jasp-stats / jasp-issues

This repository is solely meant for reporting of bugs, feature requests and other issues in JASP.
58 stars 29 forks source link

[Bug]: Correlation table messed up when column names have square brackets #2625

Closed patc3 closed 5 months ago

patc3 commented 7 months ago

JASP Version

0.18.3

Commit ID

No response

JASP Module

Regression

What analysis are you seeing the problem on?

Correlation

What OS are you seeing the problem on?

Windows 10

Bug Description

The default table (with "Display pairwise" unchecked) doesn't show properly when column names have square brackets in their name (at least I'm guessing that's what the problem is). This is how the data are exported from LimeSurvey.

image

image

image

image

This happens with or without Pearson/Spearman. The problem disappears (i.e. doesn't happen) when I check "Display pairwise":

image

Expected Behaviour

Table should have been a correlation matrix

Steps to Reproduce

  1. have column names with square brackets in their name (I assume that's what causes this)
  2. go to module regression > correlation
  3. put variables in variables box

Log (if any)

No response

Final Checklist

tomtomme commented 7 months ago

@patc3 Thanks for the report. This is a long standing known bug also for ANOVA, CFA, etc. https://github.com/jasp-stats/jasp-issues/issues/2564 https://github.com/jasp-stats/jasp-issues/issues/2113 https://github.com/jasp-stats/jasp-issues/issues/1503

Throughout those issues we gathered that the following signs should not be allowed to enter in var names & labels:

/ "+" "-" [ ]

Let us hope that this can be fixed for 0.19

patc3 commented 7 months ago

Thanks a lot for the info @tomtomme

shun2wang commented 7 months ago

Well, as I took a rough glance, the problems may not be exactly the same. Some of them with special characters in the variable name indeed. This problem also has problems with result styles, such as colspan css style matching problems. I will see what Bruno and Joris's assessment here.

JorisGoosen commented 7 months ago

@patc3 Thanks for the report. This is a long standing known bug also for ANOVA, CFA, etc. #2564 #2113 #1503

Throughout those issues we gathered that the following signs should not be allowed to enter in var names & labels:

/ "+" "-" [ ]

Let us hope that this can be fixed for 0.19

Well these really ought to be allowed... I will have a look at this before the 0.19 release comes up I hope!

JorisGoosen commented 6 months ago

I suppose I could replace those by html codes So [ -> [ and such, specifically for columnnames of jaspTables