search

jasp-stats / jasp-issues

This repository is solely meant for reporting of bugs, feature requests and other issues in JASP.
58 stars 29 forks source link

[Feature Request]: Filter & Compute Column: Bigger capture zones + easier point&click behaviour #2721

Open Jamesmacdougall opened 4 months ago

Jamesmacdougall commented 4 months ago

JASP Version

0.18.3

Commit ID

No response

JASP Module

Other

What analysis are you seeing the problem on?

Data Filter

What OS are you seeing the problem on?

Windows 10

Bug Description

Bug Fix Request.docx

Expected Behaviour

Included in the problem description

Steps to Reproduce

  1. I have tried numerous times to use the function and have failed every time.

  3. ...

Log (if any)

None

Final Checklist

boutinb commented 4 months ago

As you closed this issue, I suppose there was no error.

Jamesmacdougall commented 4 months ago

The issue remains open. Clicking the closed option was simply an error on my part. GitHub and I are still getting acquainted!

Jamesmacdougall commented 4 months ago

Bruno,

My mistake as a very inexperienced user of GitHub. I reopened the bug report.

Jim

On Wed, May 15, 2024 at 9:46 AM bruno boutin @.***> wrote:

As you closed this issue, I suppose there was no error.

— Reply to this email directly, view it on GitHub https://github.com/jasp-stats/jasp-issues/issues/2721#issuecomment-2112586117, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGTXB37TGAWPSP5RBYSKCYLZCNRK7AVCNFSM6AAAAABHUXU4FSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSGU4DMMJRG4 . You are receiving this because you modified the open/close state.Message ID: @.***>

boutinb commented 4 months ago

As filter could you use (Gender = M) ^ (Age < 50) I have tried it, and it worked. Maybe this is not really easy to do that with the Drag & Drop, but if you use directly R with: generatedFilter <- (Gender == 'M') & (Age < 50)

Jamesmacdougall commented 4 months ago

I will try it.

Thanks

On Wed, May 15, 2024 at 11:49 AM bruno boutin @.***> wrote:

As filter could you use (Gender = M) ^ (Age < 50) I have tried it, and it worked. Maybe this is not really easy to do that with the Drag & Drop, but if you use directly R with: generatedFilter <- (Gender == 'M') & (Age < 50)

— Reply to this email directly, view it on GitHub https://github.com/jasp-stats/jasp-issues/issues/2721#issuecomment-2112906335, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGTXB37Y5JN47YDK5J2ZUMTZCN72HAVCNFSM6AAAAABHUXU4FSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSHEYDMMZTGU . You are receiving this because you modified the open/close state.Message ID: @.***>

Jamesmacdougall commented 4 months ago

Hi Again,

I played with it again and had one success, i..e.: Age < 30 ^ Age > 50, which successfully activated the filter. I could not replicate it a second time in spite of 6-7 tries. Can the capture zones (?) dots (... ^ ...) be made more inclusive or better able to capture the initial and second conditions instead of dropping the operator to the next line down, which is what happens repeatedly:

    Age < 30
    ... ^ ...

Ideally, the naive user would do the following steps:

Step 1 Enter by pointing, clicking, and typing "Age < 30" Step 2 Click on ^, yielding "Age < 30 . ^ ..." Step 3 Click on trailing dots, yielding "Age < 30 . ^ ..|" Step 4 Enter by pointing, clicking, and typing "Age > 50", yielding "Age < 30 ^ Age > 50"

The R code solution is logical and fast, but it is not available to 22 year-old students--most of whom are scared shitless taking their first course in statistical methods.

Jim

On Wed, May 15, 2024 at 12:03 PM Jim MacDougall @.***> wrote:

I will try it.

Thanks

On Wed, May 15, 2024 at 11:49 AM bruno boutin @.***> wrote:

As filter could you use (Gender = M) ^ (Age < 50) I have tried it, and it worked. Maybe this is not really easy to do that with the Drag & Drop, but if you use directly R with: generatedFilter <- (Gender == 'M') & (Age < 50)

— Reply to this email directly, view it on GitHub https://github.com/jasp-stats/jasp-issues/issues/2721#issuecomment-2112906335, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGTXB37Y5JN47YDK5J2ZUMTZCN72HAVCNFSM6AAAAABHUXU4FSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSHEYDMMZTGU . You are receiving this because you modified the open/close state.Message ID: @.***>

tomtomme commented 4 months ago

I can confirm this behaviour. We definitely should improve this. Currently what happens

instead of

Age < 30 ^ ...

I also agree that the capture zones could be larger. So this is now effectively a feature request.

@Jamesmacdougall Can you alter the title to

[Feature Request] operators AND and OR harder to use than necessary

JorisGoosen commented 4 months ago

What capture zones should be better?

Im a bit hesitant to put too much development effort on this constructor as I think it would probably be better to replace it with something better altogether. Also given that some of the code in the constructor is the first qml code we added to JASP years ago and some of it doesnt quite follow best practices...

But small tweaks are definitely possible.

In this case though it is unclear to me what you mean by a "capture zone" Right now when something gets added later the constructor does try to fit things in there, to get the desired (Age < 30) ^ ..., or at least, it ought to yeah.

tomtomme commented 4 months ago

The "capture zone" is the drag and drop zone that you successfuly entered, when you can see the red or green circle which tells you "you can now drop what you have dragged". To find the zone, where you can drop something is hard, because it is small.

tomtomme commented 4 months ago

@Jamesmacdougall Can you rename the title of this request to "[Feature Request]: Filter & Compute Column: Bigger capture zones + easier point&click behaviour"

Jamesmacdougall commented 4 months ago

Hi,

It appears to have been done, so I'm assuming no action is required on my part?

Jim

On Mon, Jun 3, 2024 at 4:16 AM Thomas Langkamp @.***> wrote:

@Jamesmacdougall https://github.com/Jamesmacdougall Can you rename the title of this request to "[Feature Request]: Filter & Compute Column: Bigger capture zones + easier point&click behaviour"

— Reply to this email directly, view it on GitHub https://github.com/jasp-stats/jasp-issues/issues/2721#issuecomment-2144561667, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGTXB352QTU5FCL6PJ3GC4DZFQQ6BAVCNFSM6AAAAABHUXU4FSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBUGU3DCNRWG4 . You are receiving this because you were mentioned.Message ID: @.***>