jasp-stats / jasp-issues

This repository is solely meant for reporting of bugs, feature requests and other issues in JASP.
59 stars 29 forks source link

[Bug]: Error when saving plots as SVG #2773

Open JoKeyser opened 5 months ago

JoKeyser commented 5 months ago

JASP Version

JASP 0.19

Commit ID

2f53f98b336720bfb44241df4145741a46b1d75e

JASP Module

Descriptives

What analysis are you seeing the problem on?

No response

What OS are you seeing the problem on?

Ubuntu 22.04.4 LTS, Flatpak 1.14.4.

Bug Description

Similar to #1775, when I try to save plots as SVG, I get the error message "path must point to a valid file".

jasp-error

Note that in #1775, it's claimed that it worked fine on 0.18.3, maybe a regression?

Expected Behaviour

JASP should save the plot as SVG file.

Steps to Reproduce

  1. Select to save figure from Descriptives module, as SVG

Log (if any)

No response

Final Checklist

github-actions[bot] commented 5 months ago

@JoKeyser, thanks for taking the time to create this issue. If possible (and applicable), please upload to the issue website (https://github.com/jasp-stats/jasp-issues/issues/2773) a screenshot showcasing the problem, and/or a compressed (zipped) .jasp file or the data file that causes the issue. If you would prefer not to make your data publicly available, you can send your file(s) directly to us, issues@jasp-stats.org

tomtomme commented 5 months ago

Strange. Saving as SVG works fine for me. Maybe ubuntu specific. Or something broken in an older flatpak version. I have: flatpak --version Flatpak 1.15.8

-------- Application Info -------- JASP Version: JASP 0.19 Build Branch: HEAD Build Date: May 23 2024 21:22:50 (Netherlands) Last Commit: 2f53f98b336720bfb44241df4145741a46b1d75e

-------- Basic Info -------- Operating System: KDE Flatpak runtime Product Version: 6.7 Kernel Type: linux Kernel Version: 6.6.32-1-MANJARO Architecture: x86_64 Install Path: /app/bin System Local: de_DE

JoKeyser commented 5 months ago

@tomtomme , thanks for checking; that's strange. Maybe it's indeed specific to Ubuntu; I'm running Ubuntu 22.04.4 LTS.

We have the same app version, but Flatpak is different. And/or maybe, we have different settings within JASP..?

flatpak --version
Flatpak 1.14.4
-------- Application Info --------
JASP Version: JASP 0.19
Build Branch: HEAD
Build Date: May 23 2024 21:22:50 (Netherlands)
Last Commit: 2f53f98b336720bfb44241df4145741a46b1d75e

-------- Basic Info --------
Operating System: KDE Flatpak runtime
Product Version: 6.7
Kernel Type: linux
Kernel Version: 5.15.0-112-generic
Architecture: x86_64
Install Path: /app/bin
System Local: en_US
tomtomme commented 5 months ago

I just tried again and cleared all settings beforehand. SVG export works. I tried saving in home and in a sub-directory. Where do you try to save? I had flatpak apps in the past (like MS teams) that had only access to the Download folder.

tomtomme commented 5 months ago

Also, in the issue you linked, vandenman pointed to the font type. Do you have a non-default font set in JASP?

JoKeyser commented 5 months ago

@tomtomme thanks for checking again.

I'm trying to save to folders outside Downloads, and that works with PNG and other formats, but not with SVG. So the only difference in my behaviour is whether I set the saving option to SVG or PNG, for example. Saving to SVG also does not work when I try to save to my Downloads folder.

I'm not aware that I changed the font type, it's set to Standard: DejaVu Sans and Standard: Fira Code.

Is there a way to reset all settings?

jasp-settings1

tomtomme commented 5 months ago

My "user interface options" looks exactly like yours.

To reset all settings I delete the following folder: /home/tom/.var/app/org.jaspstats.JASP/

You could also try without "use native file dialogs" etc.

And check the content of /home/tom/.local/share/flatpak/overrides/org.jaspstats.JASP

This contains for me:

[Context] devices=all; features=devel; filesystems=home:create;host:create;host-os:create;

JoKeyser commented 5 months ago

Hmmm... ok I also tried all those things, but the problem persists; it's always the same error.

Specifically:

JoKeyser commented 5 months ago

In addition, here are JASP log files of me opening JASP, trying to save a figure as SVG, and then closing JASP:

JASP 2024-06-11 17_31_46 Engine 0.log JASP 2024-06-11 17_31_46 Desktop.log

What's surprising to me: No mention of an error in those logs... but the same error showed up in the GUI and in the standard console that I started Flatpak from. (The error message "Error: path must point to a valid file".)

tomtomme commented 5 months ago

Maybe then the missing override file is the culprit. I will try tomorrow what happens if I delete it.

tomtomme commented 5 months ago

That is also not it. Deleted the override file and can still save svgs. Maybe then it is the different-flatpak-version-thing. But as you have all noticed by now, I am clueless and grasping for straws.

@shun2wang any ideas?

JoKeyser commented 5 months ago

@tomtomme thank you for checking so much.

Now I noticed that when I try to update JASP, I get this message, do you see that as well?

flatpak update org.jaspstats.JASP
Looking for updates…

Info: runtime org.kde.Platform branch 6.5 is end-of-life, with reason:
   We strongly recommend moving to the latest stable version of the Platform and SDK
Info: applications using this runtime:
   org.jaspstats.JASP

Nothing to do.

I get the same message when I try to flatpak upgrade org.kde.Platform.

Not sure if I can to resolve this, or is this the case for everyone using flatpak?

PS: @tomtomme , could you remove the tag "waiting for requester"? I keep getting emails that some pipeline failed, probably to delete it automatically?

shun2wang commented 5 months ago

I get the same message when I try to flatpak upgrade org.kde.Platform.

Hi @JoKeyser the message what you see is not related, we will update runtime in the next release. could you share the files so we can look into it? I'ii try to reproduce...

@tomtomme This might not related to flatpak/system because flatpak including a same runtime and env for every Linux based OS.

JoKeyser commented 5 months ago

@shun2wang thanks for the clarification about org.kde.Platform.

@shun2wang , the error is not specific to any file; I can reproduce the error by opening the Sleep:Descriptives example from the Data Library (before trying to save the boxplot figure, JASP prompts me re-run the analysis, since the example was saved with an earlier version).

tomtomme commented 5 months ago

@shun2wang I suspect a flatpak bug, becaues JoKeyer: Flatpak 1.14.4 and me Flatpak 1.15.8

@JoKeyser yes, everybody gets the message about the old runtime. It is a security warning with few implications.

shun2wang commented 4 months ago

I cannot reproduce it on Linux or with flatpak. but it's not related to that.

@vandenman it might be a systemfont registry problem I guess, if I understand right in the logs:

    "resultFont" : "freesans,sans-serif",

according to https://systemfonts.r-lib.org/index.html#system-defaults and the user's settings pic it should returen "ejaVu Sans" ? from https://github.com/jasp-stats/jaspBase/blob/a5ae69e40614045667a3fbafaf337a95e8a40f3c/R/common.R#L180 should JASP register_font for all font or specified?