jasp-stats / jasp-issues

This repository is solely meant for reporting of bugs, feature requests and other issues in JASP.
58 stars 29 forks source link

[Feature request]: Enable Diagnostics/EMMs/Contrast/Advanced for Multinomial/Ordinal/Firth Logistic Regression #2926

Open patc3 opened 1 month ago

patc3 commented 1 month ago

JASP Version

0.19.0

Commit ID

No response

JASP Module

Regression

What analysis are you seeing the problem on?

Generalized Linear Model > Family = Other > Model = Multinomial Logistic Regression

What OS are you seeing the problem on?

Windows 10

Bug Description

See user report here https://forum.cogsci.nl/discussion/9512/diagnostics-in-multinomial-logistic-regression

The "Diagnostics" section of analysis doesn't affect the output in any way in Regression > Generalized Linear Model > Family = Other > Model = Multinomial Logistic Regression.

image

image

Expected Behaviour

If diagnostics are not implemented for multinomial logistic regression, the Diagnostics section of the analysis in the UI should be deactivated or hidden. If diagnostics are implemented, then checking boxes in the UI should show diagnostics in the output.

Steps to Reproduce

  1. run regression > glm > multinomial logistic regression (family other, model MLR)
  2. check and uncheck boxes under Diagnosis: output reloads but no change

Log (if any)

No response

More Debug Information

No response

Final Checklist

tomtomme commented 1 month ago

confirmed on flatpacked 0.19.1

JohnnyDoorn commented 1 month ago

Hi @patc3,

I just looked into it, and it used to be the case that the bottom three tabs (starting with "diagnostics") were not available when selecting the "Other" family. In 0.19 they accidentally became available. The easy solution for now is to disable them again, but I will leave this issue open (with updated name) so that we can at some point add the functionality.

Cheers, Johnny