jasp-stats / jasp-issues

This repository is solely meant for reporting of bugs, feature requests and other issues in JASP.
59 stars 29 forks source link

JASP Friedman Conover test doesn't match R (posthoc.friedman.conover.test) #314

Closed rachael-reavis closed 5 years ago

rachael-reavis commented 5 years ago
JohnnyDoorn commented 5 years ago

Hi Rachael, Could you please provide a .jasp or csv file? If you prefer, you can send it to me at j.b.vandoorn(at)uva.nl Kind regards, Johnny

JohnnyDoorn commented 5 years ago

Got it, thanks Rachael - I will look into this!

JohnnyDoorn commented 5 years ago

Hi Rachael,

Wanted to let you know that this is now fixed in the next JASP release. The issue was a package upgrade that we were not aware of. We used part of the PMCMRplus package, which is the sequal to the PMCMR package. It seems that the Conover test differs in results between these two packages, and I believe the output from PMCMRplus is the correct one. JASP now gives the same results as that one again. Please let me know / reopen this issue if you have any additional questions/comments!

Kind regards Johnny

rachael-reavis commented 5 years ago

Thanks!

On Fri, Mar 29, 2019 at 10:01 AM JohnnyDoorn notifications@github.com wrote:

Closed #314 https://github.com/jasp-stats/jasp-issues/issues/314.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jasp-stats/jasp-issues/issues/314#event-2239324678, or mute the thread https://github.com/notifications/unsubscribe-auth/AKBIDL2B4yrl70hK8QL7a8P8BIgoiAQUks5vbhysgaJpZM4bQKjY .

ksp200425 commented 5 months ago

Hi, I have a question on this. Has there been any issues with this update and PMCMRplus? I haven't been able to get the same results for the Conover test between R (with PMCMRplus) and JASP.

JohnnyDoorn commented 5 months ago

Hi @ksp200425,

Do you have a numeric example? When I conduct a Conover test in JASP and PMCMRplus I get the same results, for instance for the Bush Tucker Food example from the data library:

image

JASP file (change extension to .jasp): BushTuckerFoodConover.zip

Running it in R:

dat <- read.csv("Bush Tucker Food.csv")
# convert to long:
y <- unlist(dat[, 2:5])
gr <- rep(letters[1:4], each = 8)
id <- rep(1:8, 4)
PMCMRplus::frdAllPairsConoverTest(y, gr, id, p.adjust.method = "holm")

    Pairwise comparisons using Conover's all-pairs test for a two-way balanced complete block design

data: y, groups and blocks

  a      b      c     
b 0.0054 -      -     
c 0.0082 0.7991 -     
d 0.2565 0.2071 0.2565

P value adjustment method: holm

Kind regards Johnny

ksp200425 commented 5 months ago

Ok I see, I did get it right in R, but for some reason got something different in JASP. I'm sorry if there is something I'm missing! image .

JohnnyDoorn commented 5 months ago

My apologies, I was using the development version of JASP (available here), which already included a fix to bring the JASP results up to date with PMCMRplus, which also had a bug fix in their latest release. The new version will officially release somewhere in the coming weeks though!

ksp200425 commented 5 months ago

Oh, Thank you so much! I will try it again with the development version.