search

jasp-stats / jaspLearnBayes

A module to help learn bayesian statistics
GNU General Public License v3.0
3 stars 15 forks source link

Proposed fix for release bug #2647 #217

Closed kylelang closed 4 months ago

kylelang commented 4 months ago

This PR should fix release bug #2647.

The original issue is caused by a limitation of JAGS. The JAGS implementation of the beta distribution requires strictly positive shape parameters. This PR attempts to enforce this restriction in two ways:

  1. Imposing a small positive minimum value on the relevant QML fields.
  2. Checking for non-positive values in the R code when parsing the analysis options (so the restriction is still honored when calling the R routines outside the JASP GUI).
kylelang commented 4 months ago

I need to fix the unit tests. This PR isn't actually ready for review.

kylelang commented 4 months ago

As far as I can tell, this PR should be ready to review/merge. The failed i18n check doesn't seem to relate to any of my changes. The failed Mac test may be a meaningful problem, but I don't have access to a Mac on which to debug the issue.