search

jasper-software / jasper

Official Repository for the JasPer Image Coding Toolkit
http://www.ece.uvic.ca/~mdadams/jasper
Other
223 stars 101 forks source link

Don't force debug suffix #351

Closed theta682 closed 1 year ago

theta682 commented 1 year ago

The external build system can specify debug suffix if it is needed. Close #350.

theta682 commented 1 year ago

@mdadams @jubalh

jubalh commented 1 year ago

Thanks! It would be great if you could write something like "Close number_ofissue" or instead of "Close" use "regards". Just it will be easier later to remember WHY we did this change (if it gets merged).

mdadams commented 1 year ago

@theta682 Could you please try merging the latest changes from master into your PR. It appears that the brew folks made some changes that broke the CI check on macOS for your PR. I have fixed this brew issue now on master. So, it would be good to know that the CI build still works with your change. (Also, a few additional items have been added to the CI test matrix, which would be good to check as well.)

@jubalh Are you otherwise okay with this PR now?

theta682 commented 1 year ago

@mdadams macos succeeded now

jubalh commented 1 year ago

jubalh Are you otherwise okay with this PR now?

Yes I think it is fine :) Except that the commit message still doesn't contian the mention to the issue.

@theta682 I think you only changed it here on GitHub and not the actual commit message. You would have to do a git commit --amend then can reedit the message to include the close.. and then a git push -f.

The goal is to have the refernce in the git history and not only here. So that if someone debugs jasper and checks the git history can find the according issue that the commit tries to fix.

mdadams commented 1 year ago

@theta682, if you can revise the commit message as @jubalh has requested, we can merge your PR.

jubalh commented 1 year ago

I added the text to the commit message.

Thanks @theta682 for the patch.

Osyotr commented 1 year ago

This is wrong. Upstream should decide what is the name of their library, not end users!