search

jasper-software / jasper

Official Repository for the JasPer Image Coding Toolkit
http://www.ece.uvic.ca/~mdadams/jasper
Other
217 stars 103 forks source link

Add reference of CVE-2021-3443 to NEWS file #362

Closed jubalh closed 8 months ago

mdadams commented 8 months ago

Michael, any ideas why the macos builds are failing? This seems rather bizarre. As they work for me, and your changes do not change anything other than a text file, unless my eyes are deceiving me. Also, I am not sure why the Ubuntu 20.04 gcc case is being run at all. I disabled this due to an apparent Ubuntu bug (which i documented in the GitHub Actions workflow file in a recent commit.) Maybe GitHub Actions is using a different version of the workflow file for your PR? These matters aside, I see no problem with your PR.

jubalh commented 8 months ago

Hm the macos test seems to fail because of some package from homebrew. But on master (where later commits happened) it isn't so I guess it was something temporary. I'll try to trigger a rebuild :)

mdadams commented 8 months ago

Triggering a rebuild would be helpful to that I know what I am getting myself into if I merge the PR. Clearly, your change should not break any builds/tests. But it would be helpful to know if the problem was transient or is new (so I know if I will have to spend time fixing a GitHub runner problem if it was not temporary). I have noticed that GitHub does not keep the OS snapshots in its runners fixed, which is quite annoying since they often introduce breaking changes in their runners and then stuff that passed CI tests before suddenly breaks through no fault of our own.

jubalh commented 8 months ago

Looks like macos is building fine now. Not sure what's going on with Ubuntu 20.04 gcc CI.

mdadams commented 8 months ago

My assessment of the situation is described in the comment that I added in the following recent commit: da765f5. I think that Ubuntu broke things. So, I am not currently concerned about the 20.04+GCC case failing.