mdadams
commented
1 year ago @tanabi I had a quick look at your changes and they seem reasonable to me. I didn't dig into the details of the main implementation file, but the other files looked reasonable. You said that your code does not save grayscale. I wasn't clear if it sliently does the wrong thing (i.e., by saving color instead of grayscale) or gives an error. I think that an error would be much better than silently doing the wrong thing (i.e., silently and incorrectly saving color instead of grayscale would be bad.) If you don't give an error in this case, I think that you should. (Of course, saving grayscale would be better, but I appreciate that you may not have time/motivation to do this.) I would also suggest that you add a few small image files (in the webp format) for testing purposes to the data/images directory. It is extremely important that the images used not cause copyright issues. So, I would suggest deriving the images from the ones already in the images directory (by cropping/warping and format conversion) since the images in this directory should be clean as for as copyright is concerned. If you have some small images of your own for which you own the copyright, this would be okay as well.
@pghmcfc What do you think about this PR? Would you be okay with it being merged (since you are using this code base in Fedora, I wanted to ask your opinion).
tanabi
pghmcfc
This commit addresses issue #7 and gives xv webp support.
Some 'release notes':
apt-get install libwebp-devThis does NOT open webp animated files. There is probably a way to make it show the first frame of the WebP animation, however the documentation is pretty bad and I'd have to go spelunking in libwebp's headers to figure it out. That's outside of my timebox for this project so we'll just have to live with it as is.
I have tested it with and without alpha channel and in many different sizes, and it loads all of them fine. If the webp has an alpha channel the transparent areas come up in a really unattractive way, but I don't think XV handles transparency very well (or maybe at all) so I think it just is what it is.
It can save WEBP files, but it does so in a very basic fashion. WebP has a lot of options -- especially around "lossy" style images -- and to open that up for everything was going to turn this into a multi-day codestravagnza that I don't have time for. So I made it save lossless and use the default settings, and it works.
Verfied it works correctly in full color, reduced color, greyscale, and BW dither modes (as selected from the save dialog).
Verified "visual schauzer" will make icons of webp images.
I think that's it. I properly supported it in CMake and it detects libwebp if you have it installed. I didn't touch the Makefile / Imakefile as I assume those are legacy build files, but let me know if we need to support them and I can probably make it work. Let me know if you have any questions!
Resolves #7