search

jasperges / pose-thumbnails

Blender add-on that adds thumbnails to a pose library.
GNU General Public License v2.0
67 stars 11 forks source link

Linear interpolation of matrix elements is a bad idea #38

Closed sybrenstuvel closed 6 years ago

sybrenstuvel commented 6 years ago

https://github.com/jasperges/pose_thumbnails/blob/e80726b23d7ee9d5245ac7914c3c0d5fadf90833/pose_thumbnails.py#L301

This performs interpolation of two poses by linear interpolation of the 16 components of the matrix. This is a bad idea and can cause unexpected results. The matrix should be decomposed and the components interpolated appropriately (linearly for translation, quaternion-SLERP for rotation, etc.). Also see this answer on Stack Exchange.

jasperges commented 6 years ago

Thanks for pointing out this and other issues. At the moment I don't have time to look at them, but I will when I have time again.