jaspermayone-archive / api

Basic API, designed and coded for the @Heptagram-Bot-Project
http://api.heptagrambotproject.com
Eclipse Public License 2.0
2 stars 8 forks source link

Open Source Quotes #24

Closed naomi-lgbt closed 2 years ago

naomi-lgbt commented 2 years ago

When a quote doesn't have author data, the response includes a request to email you if someone knows the author. Rather than an email based approach, why not open source the quotes?

The structure of the data is simple enough to be effective in a JSON object, can be hosted directly in the API files, and then you'd be able to accept contributions.

Could also consider this for your jokes data as well.

jaspermayone commented 2 years ago

We did do this to start, but as the database of various things grows, it makes more sense to have it in something like a MongoDB Atlas instance. Wrather than migrating everything when it gets to that point. I would rather have them already migrated as much as possible. Currently there is about 100 quotes that need authors, and I have that data with authors stored, I just need to finish updating it. The /add endpoints all have validation on them, meaning that there won't be any more data lacking authors.

jaspermayone commented 2 years ago

Controlling the data like this also allows us to make sure no inappropriate jokes or quotes are added to the dataset.

jaspermayone commented 2 years ago

I am going to keep this open as an discussion, in case others want to chime in.